Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with doc on constructors #1211

Open
tatchi opened this issue Nov 14, 2023 · 4 comments
Open

Issue with doc on constructors #1211

tatchi opened this issue Nov 14, 2023 · 4 comments
Labels
bug Something isn't working merlin

Comments

@tatchi
Copy link
Collaborator

tatchi commented Nov 14, 2023

without params:

Screen.Recording.2023-11-14.at.11.36.06.mov

with params:

Screen.Recording.2023-11-14.at.11.39.57.mov
@voodoos
Copy link
Collaborator

voodoos commented Nov 14, 2023

This is probably an upstream issue in Merlin.
Which version of OCaml / merlin-lib are you using ?

@tatchi
Copy link
Collaborator Author

tatchi commented Nov 14, 2023

This is probably an upstream issue in Merlin. Which version of OCaml / merlin-lib are you using ?

ocaml --version
The OCaml toplevel, version 5.0.0
ocamllsp --version
1.16.2
merlin-lib            4.9-500     Merlin's libraries

@jfeser jfeser added merlin bug Something isn't working labels Dec 12, 2023
@tatchi
Copy link
Collaborator Author

tatchi commented Mar 19, 2024

@voodoos should we move this issue to Merlin repo?

Also, would creating a test for this be helpful? After a quick look, it seems that adding something to https://github.com/ocaml/merlin/tree/master/tests/test-dirs/document might be the right place?

@voodoos
Copy link
Collaborator

voodoos commented Apr 3, 2024

@voodoos should we move this issue to Merlin repo?

Also, would creating a test for this be helpful? After a quick look, it seems that adding something to https://github.com/ocaml/merlin/tree/master/tests/test-dirs/document might be the right place?

Actually, there is already a similar test: https://github.com/mheiber/merlin/blob/master/tests/test-dirs/document/issue1513.t
Having the issue tracked on Merlin's repository and completing that test or adding a new one would be useful indeed :-)

I expect some of these issues to be fixed when moving to OCaml 5.2 which should allow more precise determination of comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working merlin
Projects
None yet
Development

No branches or pull requests

3 participants