Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: the release script unexpectedly runs tar #595

Open
erikmd opened this issue Feb 29, 2024 · 0 comments
Open

Bug: the release script unexpectedly runs tar #595

erikmd opened this issue Feb 29, 2024 · 0 comments
Assignees
Labels
kind: bug kind: infrastructure CI, build tools, development tools priority: high

Comments

@erikmd
Copy link
Member

erikmd commented Feb 29, 2024

Related user(s):

@erikmd, @AltGr

Related issue(s) or PR(s):

Related project scope(s):

No response

Bug description:

Run cd artifacts
  cd artifacts
  mkdir -v target
  dist=(linux darwin)
  artifact() { printf "learn-ocaml-%s-x86_64.tar.gz" "$d"; }
  for d in "${dist[@]}"; do
    mkdir -v -- "$d"
    ( cd "$d" && tar xvzf "../$(artifact "$d")/$(artifact "$d")" )
    bin=(./learn-ocaml-client ./learn-ocaml-server ./learn-ocaml)
    for b in "${bin[@]}"; do
      mv -v -- "$d/$b" "target/$b-$d-x86_64"
    done
  done
  mv -v -- learn-ocaml-www.zip target/learn-ocaml-www.zip
  shell: /usr/bin/bash -e {0}

mkdir: created directory 'target'
mkdir: created directory 'linux'
tar (child): ../learn-ocaml-linux-x86_64.tar.gz/learn-ocaml-linux-x86_64.tar.gz: Cannot open: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now
Error: Process completed with exit code 2.

To reproduce:

  • Merge a release-please PR.

Expected behavior:

  • the static binaries and *www.zip are properly added as release artifacts

learn-ocaml --version

1.0.0

git describe --long --always --abbrev=40 --tags

No response

What OS do you use?

GNU/Linux

What OS version/distribution do you use?

Debian

What browser(s) do you use with learn-ocaml?

No response

What browser(s) version did you used to reproduce the issue?

No response

Screenshots (if need be):

No response

Additional context:

Manually fixed using:

wget -r -w 1 https://ocaml-sf.org/learn-ocaml/artifacts/
gh auth login
gh release -R ocaml-sf/learn-ocaml upload "v1.0.0" $(find artifacts_to_publish -type f -printf "%p ")
@erikmd erikmd added kind: bug kind: infrastructure CI, build tools, development tools priority: high labels Feb 29, 2024
@erikmd erikmd changed the title Bug: fix release script Bug: the release script unexpectedly runs tar Feb 29, 2024
@erikmd erikmd assigned AltGr and erikmd and unassigned AltGr Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug kind: infrastructure CI, build tools, development tools priority: high
Projects
None yet
Development

No branches or pull requests

2 participants