Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Integrate feedback from https://github.com/ocsigen/js_of_ocaml/issues/1436 #530

Open
erikmd opened this issue Mar 26, 2023 · 0 comments
Labels
kind: enhancement Enhancement to an existing user-facing feature.

Comments

@erikmd
Copy link
Member

erikmd commented Mar 26, 2023

Related user(s):

@erikmd, @hhugo

Related issue(s) or PR(s):

Related project scope(s):

web-app UI

Question?

  • TODO: Apply @hhugo's suggestion to avoid using Js.Unsafe.js_expr.
  • Next: Understand whether we can avoid Obj.magic and/or directly use (a modified version of) Dom_html.handler

What has already been tested:

No response

learn-ocaml --version

No response

git describe --long --always --abbrev=40 --tags

No response

What OS do you use?

GNU/Linux

What browser(s) do you use with learn-ocaml?

No response

Additional context:

No response

@erikmd erikmd changed the title Question: Integrate feedback from https://github.com/ocsigen/js_of_ocaml/issues/1436 ? Question: Integrate feedback from https://github.com/ocsigen/js_of_ocaml/issues/1436 Mar 27, 2023
@erikmd erikmd changed the title Question: Integrate feedback from https://github.com/ocsigen/js_of_ocaml/issues/1436 Task: Integrate feedback from https://github.com/ocsigen/js_of_ocaml/issues/1436 Mar 27, 2023
@erikmd erikmd added kind: enhancement Enhancement to an existing user-facing feature. and removed kind: question labels Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Enhancement to an existing user-facing feature.
Projects
None yet
Development

No branches or pull requests

1 participant