Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docker): Refine the .dockerignore as a whitelist #471

Merged
merged 1 commit into from Mar 6, 2022

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Mar 6, 2022

  • Kind: cleanup

Description

  • many potential folders/files to ignore (e.g. _build) were not listed
  • let's bluntly ignore what is not required by the Dockerfiles

Checklist

Note to maintainers

  • Read this wiki page
  • Make sure the PR has a milestone
  • Assign yourself before merging
  • We can squash-merge 1-commit PRs (use a header with a conventional-commit type, add a footer with Fix #… if need be)

* many potential folders/files to ignore (e.g. _build) were not listed
* let's bluntly ignore what is not required by the `Dockerfile`s
@erikmd
Copy link
Member Author

erikmd commented Mar 6, 2022

All CI workflows were fine, so merging this small cleanup PR.

@erikmd erikmd self-assigned this Mar 6, 2022
@erikmd erikmd merged commit 41706ea into ocaml-sf:master Mar 6, 2022
@erikmd erikmd deleted the update-dockerignore branch March 6, 2022 00:56
@erikmd erikmd added this to the learn-ocaml 0.14.0 milestone Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant