Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Build learn-ocaml-www.ziplearn-ocaml --contents-dir=www #469

Merged
merged 1 commit into from Mar 4, 2022

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Mar 4, 2022

  • Kind: feature

Description

The aim is to build/deploy (among the release assets) an archive learn-ocaml-www.zip so that we can do:

unzip learn-ocaml-www.zip
mkdir server && cd server
learn-ocaml build serve --contents-dir="$(readlink -f ../www)"

Checklist

Note to maintainers

  • Read this wiki page
  • Make sure the PR has a milestone
  • Assign yourself before merging
  • We can squash-merge 1-commit PRs (use a header with a conventional-commit type, add a footer with Fix #… if need be)

@erikmd erikmd added the kind: feature New user-facing feature. label Mar 4, 2022
@erikmd erikmd added this to the learn-ocaml 0.14.0 milestone Mar 4, 2022
@erikmd
Copy link
Member Author

erikmd commented Mar 4, 2022

Apparently, looks fine (I did a diff -r -u between the artifact and a previous, manual version of the archive).

@yurug yurug merged commit e36d874 into ocaml-sf:master Mar 4, 2022
@erikmd erikmd deleted the learn-ocaml-www.zip branch March 4, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature New user-facing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants