ci: Ensure release-please triggers docker/build-push-action jobs #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This wasn't automatic up to now because these jobs was in a separate workflow and the tagging or release events that occur in release.yml cannot trigger children workflows from a mere "secrets.GITHUB_TOKEN" * href: https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token
Closed
15 tasks
|
Hi @yurug, I've proofread the workflow code once more and everything looks fine; so squash-merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't automatic up to now because these jobs was in a separate workflow and the tagging or release events that occur in
release.ymlcannot trigger children workflows from a meresecrets.GITHUB_TOKENFor details, see https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token
I tested this approach as realistically as possible in our dummy separate repo, but I guess the very test will be on the next release.
Anyway @yurug feel free to proofread this refactoring in case you'd see a typo somewhere…