Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release.yml): Add a (3 jobs)-based GHA using release-please #434

Merged
merged 1 commit into from Oct 5, 2021

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Oct 4, 2021

This PR is the very last touch needed to prepare/automate 0.13.0 and upcoming releases:

  • We just need to git commit --allow-empty -m "chore: release 0.13.0" -m "Release-As: 0.13.0" && git push
    (in master)
  • Then, this creates a Release PR
  • We can double-check the generated Changelog (otherwise, maybe add commits in the PR branch but do not merge other PRs)
  • Merge the Release PR
  • Then:
    • A tag is pushed
    • A GH release is created
    • Static binaries are generated and added in the release
    • An opam PR is created using opam-publish
    • And like before, Docker images for server/client are tagged and pushed

@yurug I plan to merge/use this PR soon; feel free to have a look if you can/want (anyway, I'll double-check the outcome "in pre-prod" beforehand with the dummy project we created)

@erikmd erikmd added kind: feature New user-facing feature. kind: infrastructure CI, build tools, development tools labels Oct 4, 2021
@erikmd erikmd requested a review from yurug October 4, 2021 23:27
@erikmd erikmd added this to the learn-ocaml 0.13.0 milestone Oct 4, 2021
@erikmd erikmd force-pushed the use-release-please branch 5 times, most recently from a0cdaa1 to 059aea9 Compare October 5, 2021 16:49
* Use var OPAM_RELEASE (GitHub PAC)

* Use "expect" to workaround the lack of this feature:
  ocaml-opam/opam-publish#132

Co-Authored-By: Yann Régis-Gianas <yann@regis-gianas.org>
Co-Authored-By: Erik Martin-Dorel <erik@martin-dorel.org>
@erikmd
Copy link
Member Author

erikmd commented Oct 5, 2021

FYI @yurug, all details of the whole workflow release.yml are very fine now according to my tests; so let's merge/release now :)

@erikmd erikmd merged commit 7e389ef into ocaml-sf:master Oct 5, 2021
@erikmd erikmd deleted the use-release-please branch October 5, 2021 20:13
@erikmd erikmd self-assigned this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature New user-facing feature. kind: infrastructure CI, build tools, development tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant