Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Release a new version (0.13 ?) to update docker image #417

Closed
asere opened this issue Sep 13, 2021 · 4 comments
Closed

Feat: Release a new version (0.13 ?) to update docker image #417

asere opened this issue Sep 13, 2021 · 4 comments
Labels
kind: feature New user-facing feature. kind: question

Comments

@asere
Copy link
Contributor

asere commented Sep 13, 2021

Related issue(s) or PR(s): None
Related project scope(s) (ex: client, CSS, grading, etc...) : Docker
Related user(s): teachers of Learn-OCaml-Essok

The problem

Actually, we use the learn-ocaml-corpus made by Mr.Alain in learn-ocaml-essok. Unfortunately, theses exercises do not work with Learn-OCaml v0.12 (I think this is due to conception of new exercises using the last version of Learn-OCaml).

Wanted solution

As a solution, we will need a new release, that way we can update our learn-ocaml-dockerfile Dockerfile to make exercises work properly.

Considered alternatives

As a workaround, I have created a custom docker repository (using learn-ocaml:master docker image) to make exercises working.

@asere asere added the kind: feature New user-facing feature. label Sep 13, 2021
@erikmd
Copy link
Member

erikmd commented Sep 13, 2021

Thanks for the report! I was thinking that learn-ocaml-corpus was still compatible with ocamlsf/learn-ocaml:0.12

So I tried to reproduce the issue and got this error indeed:

$ cd learn-ocaml-corpus
$ docker run --rm -it -v "$PWD:/repository" ocamlsf/learn-ocaml:0.12
Learnocaml v.0.12 running.
Updating app at ./www   
Cannot process exercises: Unix.Unix_error(Unix.EEXIST, "mkdir", "./www/static")  

− side question: do you believe you got the same error, or another one?

So, indeed we should make a release to overcome this
(in the meantime I guess you can do FROM ocamlsf/learn-ocaml:master in your Dockerfile, but you're right that having a new release tag would be much more stable… (BTW, I'm unsure why it was necessary for you to create another custom Docker Hub repo asere/learn-ocaml-essok-dockerfile:master because you might have used ocamlsf/learnocaml-essok-dockerfile:master))

Regarding the release, @yurug and I need to discuss a number of things for preparing the release, and we plan to video-meet soon, then when we've some news, we'll be able to comment in this issue :)

@asere
Copy link
Contributor Author

asere commented Sep 14, 2021

So I tried to reproduce the issue and got this error indeed:

$ cd learn-ocaml-corpus
$ docker run --rm -it -v "$PWD:/repository" ocamlsf/learn-ocaml:0.12
Learnocaml v.0.12 running.
Updating app at ./www   
Cannot process exercises: Unix.Unix_error(Unix.EEXIST, "mkdir", "./www/static")  

− side question: do you believe you got the same error, or another one?

Yes, this is exactly the error I have on some exercises.

(in the meantime I guess you can do FROM ocamlsf/learn-ocaml:master in your Dockerfile, but you're right that having a new release tag would be much more stable… (BTW, I'm unsure why it was necessary for you to create another custom Docker Hub repo asere/learn-ocaml-essok-dockerfile:master because you might have used ocamlsf/learnocaml-essok-dockerfile:master))

Yes, I have thought about that. I highly prefer to avoid making PR in learn-ocaml-dockerfile for workarounds.

@erikmd
Copy link
Member

erikmd commented Sep 15, 2021

OK @asere! thanks for your feedback.

So @yurug and I were able to discuss today, so if everything goes smoothly… we could release learn-ocaml 0.13 by the end of this week 😅

(FYI we opened a "meta-issue" to recap the remaining steps to address: #418)

@erikmd
Copy link
Member

erikmd commented Oct 6, 2021

Closed by #435

@erikmd erikmd closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature New user-facing feature. kind: question
Projects
None yet
Development

No branches or pull requests

2 participants