feat: Make the prelude available in description page #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmd
reviewed
May 13, 2021
erikmd
reviewed
May 13, 2021
YoanwM
force-pushed
the
text_tab_prelude
branch
2 times, most recently
from
c700ead
to
02f3f08
Compare
erikmd
added
the
kind: enhancement
|
It would be nice to have a description for this PR. |
Closed
15 tasks
|
Rebasing this PR… |
erikmd
force-pushed
the
text_tab_prelude
branch
from
02f3f08
to
271c033
Compare
erikmd
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
It would be nice to have a description for this PR.
Done.
I think this PR can now be merged.
FWIW, below are some screenshots in four different situations.
with a prelude / full mode
with a prelude / responsive mode
with no prelude / full mode
with no prelude / responsive mode
erikmd
changed the title
erikmd
added a commit
to pfitaxel/learn-ocaml
that referenced
this pull request
Oct 3, 2021
* Make the prelude available in description page * fix(description.html): Load learnocaml_tryocaml.css & Comment-out unneeded file * fix(description): Initially show the Prelude * fix(description): Simplify/Fix HTML+CSS+Js_of_ocaml for the prelude Co-authored-by: Erik Martin-Dorel <erik.martin-dorel@irit.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a Prelude pane in the
/descriptionview of an exercise (if itsprelude.mlis nonempty).Just to recall, this is intended to be used with learn-ocaml-mode, where the browser will only display questions (no code editor).