Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newer version of OCaml #387

Closed
Ailrun opened this issue Mar 27, 2021 · 11 comments
Closed

Support newer version of OCaml #387

Ailrun opened this issue Mar 27, 2021 · 11 comments
Assignees
Labels
kind: enhancement Enhancement to an existing user-facing feature.

Comments

@Ailrun
Copy link

Ailrun commented Mar 27, 2021

As tools like ocaml-lsp, merlin, etc. stopped the support for OCaml 4.05, it becomes harder to use both offline environment and LearnOCaml based on needs.

It will be great if LearnOCaml updates to or somehow supports newer OCaml versions, like 4.12.

@yurug
Copy link
Collaborator

yurug commented Mar 27, 2021

That's indeed something we plan to do in the close future.

@Ailrun
Copy link
Author

Ailrun commented Mar 27, 2021

Out of curiosity, what are the difficulties of the update? Maybe I can help remedying some of those...

@erikmd
Copy link
Member

erikmd commented Apr 16, 2021

Hi @Ailrun, thanks for opening this issue; actually the migration to a newer OCaml you suggest was already on our roadmap!

what are the difficulties of the update?

basically, a large part of the codebase need to be refactored, including (but not limited to): the embedded toplevel, and the ppx support… given that both components are highly coupled with the version of OCaml!

The good news is that we now have an ETA for completing this migration: no later than July 2021, so definitely before the next Autumn term.
BTW I recently discussed this with @AltGr, who will start working on this migration in a couple of weeks, so I take the opportunity to mark him as assignee for this issue :)

@hannelita
Copy link

Hi folks!
@Ailrun and team, I tried updating the OCaml version at the McGill fork (https://github.com/teaching-the-art-of-fp/learn-ocaml), and the main issue was related to js_of_Ocaml. I had to bump the version we use, and it broke many parts of the toplevel.

@erikmd
Copy link
Member

erikmd commented Apr 16, 2021

Hi @hannelita, thanks for your feedback!

Just to summarize/clarify, you're also interested in migrating to OCaml 4.12 or so, but didn't finalize the migration IIUC.

In this case, I hope the fact that learn-ocaml only works with 4.05.0 for now is not a blocking issue for you…

anyway, when discussing with Louis, the announced ETA for July (maybe early July) did look feasible… but it's difficult to have a more precise ETA at this time 😅

@EmileRolley EmileRolley added the kind: enhancement Enhancement to an existing user-facing feature. label Jun 23, 2021
@AltGr
Copy link
Collaborator

AltGr commented Jul 20, 2021

Update on this (@gasche) due to the big pending PRs and to avoid too many conflicts, I've been asked to hold work on this as of yet; I still hope to be able to have it done before classes start in September.

@gasche
Copy link
Contributor

gasche commented Jul 20, 2021

Thanks for the update!

@AltGr
Copy link
Collaborator

AltGr commented Jul 28, 2021

Ok seems I'm catching up, ref. #408 😅

@erikmd
Copy link
Member

erikmd commented Sep 15, 2021

Hi! #408 is now merged (to be released in upcoming learn-ocaml 0.13) so I guess I can close this issue now.

@erikmd erikmd closed this as completed Sep 15, 2021
@erikmd
Copy link
Member

erikmd commented Sep 15, 2021

In the meantime (just to recall), the continuously-deployed image ocamlsf/learn-ocaml:master now exposes a 4.12 toplevel.

@Ailrun
Copy link
Author

Ailrun commented Sep 15, 2021

Awesome, thank you for the notice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Enhancement to an existing user-facing feature.
Projects
None yet
Development

No branches or pull requests

7 participants