Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate golangci-lint enabled linters in the config #212

Open
matej-g opened this issue Jan 19, 2022 · 0 comments
Open

Consolidate golangci-lint enabled linters in the config #212

matej-g opened this issue Jan 19, 2022 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@matej-g
Copy link
Contributor

matej-g commented Jan 19, 2022

It seems that we are currently enabling all linters in our config, however it seems not all of them are useful to us, for example:

  • There are plenty of nolint:gochecknoglobals and nolint:gochecknoinits directives, although we are aware of the reasons we're using global / init() for particular source files in our code base
  • exhaustivestruct seems to be also only recommended for special cases, but we're enabling it without (I think) a good reason

The ideal outcome of resolving the issue: We have understanding of which linters cause more noise than add value and these linters are disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant