Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: OBS-ndi changes scene name arbitrarily #974

Open
wpl-test opened this issue Feb 6, 2024 · 1 comment
Open

[Bug]: OBS-ndi changes scene name arbitrarily #974

wpl-test opened this issue Feb 6, 2024 · 1 comment

Comments

@wpl-test
Copy link

wpl-test commented Feb 6, 2024

Operating System Version

Windows11

CPU

No response

GPU

No response

NDI Devices

No response

OBS Version

29.1.3~30.0.2

OBS Installation Method

exe

OBS-NDI Version

4.12.0~4.13.0

OBS-NDI Installation Method

exe

[Extra] Installation Steps

No response

OBS Log [URL]

No response

NDI Version

5.6.0.0

Describe the bug

If scene names overlap between different scene collections, the scene names will be changed automatically.
This issue does not occur in safe mode, so after verifying it, it does not occur if "NDI Output settings" is turned off.

Steps to reproduce the problem

  1. Create scene “test” in scene collection “01”
    スクリーンショット 2024-02-06 153315
  2. Create scene “test” in scene collection “02”
    スクリーンショット 2024-02-06 153411
  3. When you return to scene collection “01”, scene “test” has been changed to “test 2”.
    スクリーンショット 2024-02-06 153646

If "NDI Output settings" is turned off, this problem will not occur.
スクリーンショット 2024-02-06 154010
スクリーンショット 2024-02-06 154219
スクリーンショット 2024-02-06 154243

Expected behavior

No response

Screenshots

No response

Additional context

No response

@BitRate27
Copy link
Contributor

This is because the COLLECTION_CLEANUP event is not acted on in preview_output.cpp:
Add this case in the on_preview_scene_changed callback:
case OBS_FRONTEND_EVENT_SCENE_COLLECTION_CLEANUP:
obs_source_release(ctx->current_source);
ctx->current_source = nullptr;
break;
Because we don't release the source, the previous collection isn't cleaned up. When a new collection is selected with a duplicate scene name, it thinks there is already a scene with that name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants