Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation for devices and the materials that the devices uses #497

Closed
wdduncan opened this issue Sep 20, 2021 · 25 comments · Fixed by #511
Closed

Relation for devices and the materials that the devices uses #497

wdduncan opened this issue Sep 20, 2021 · 25 comments · Fixed by #511

Comments

@wdduncan
Copy link
Collaborator

Is there a relation that holds between a device, such as a hematology analyzer, and the specimen/sample that device uses to produce the result?
Prov has a used predicate, but that holds between an activity and the thing the activity used.

Could add a utilizes relation? E.g, hemotology-device#1 utilizes blood-sample#1

cc @cmungall @matentzn @balhoff @dosumis

@wdduncan
Copy link
Collaborator Author

P.S. I realize that this can be done with a complex pattern like

hemotology-device#1 has-disposition 
  [a disposition; realized in [a analysis-process; has-input blood-sample#1]]

But that seems like quite a lot to have to say.

@linikujp
Copy link

linikujp commented Sep 21, 2021

I think the device utilizes specimen is a shortcut relation. This is my use case:
a diagnostic testing device - is capable of - RT-PCR assay; and RT-PCR assay -has specified input - a specimen

@cmungall
Copy link
Contributor

I think the property chain makes sense, but the name 'utilizes' seems more general

how about naming this "capable-of-has-specified-input"?

Note you won't be able to make this in RO without importing OBI which introduces modularity issues

what about capable-of-has-input?

@linikujp
Copy link

linikujp commented Sep 27, 2021 via email

@wdduncan
Copy link
Collaborator Author

wdduncan commented Oct 4, 2021

I agree with @linikujp. "capable-of-has-input" will not be an easily accessible term. We can, of course, define a property chain on the relation:

'capable of' o 'has input'

I'm fine with with label utilizes. Another option might be processed by.

@linikujp
Copy link

linikujp commented Oct 4, 2021 via email

@wdduncan
Copy link
Collaborator Author

wdduncan commented Oct 4, 2021

The 'capable of' o 'has input' property chain does not need to be restricted to assays. It is restricted to cases in which a material entity is an input to a process.

The collection of specimens is an interesting case. There is come kind of specimen collection process going on. Not sure if you want to say that the device utilizes specimen, though.

@linikujp
Copy link

linikujp commented Oct 4, 2021 via email

@wdduncan
Copy link
Collaborator Author

wdduncan commented Oct 4, 2021

I think for cases in which there are outputs that are produced by the device, utilizes seems fine. For cases of storing samples, utilizes seems wrong. For example, a freezer utilizes freon to produce/output a cold environment. It seems to odd to say that the freezer utilizes the items stored inside of it. Located in or some relation like it, seems more appropriate.

@linikujp
Copy link

linikujp commented Oct 4, 2021 via email

@linikujp
Copy link

OBI call today (01/10/2022) discovered the conflict:
OBI has been using "utilizes" linking process to device long time ago, and we are using utilizes for device to material. The OBI accidentally obsoleted the "utilizes" relation and they are reviving this relation.
Both are short relations. @wdduncan we need to resolve the conflict. We may create a new relation specifically for device to material rather than fix the utilizes. And I could propose to OBI that utilizes will be the reverse relation of 'capable of' in our setting.

@linikujp
Copy link

obi-ontology/obi#1480

@linikujp
Copy link

@wdduncan Can we finalize the relation from device to specimen?

@wdduncan
Copy link
Collaborator Author

@linikujp Sorry, I am not following you. Are you suggesting a new label?

@linikujp
Copy link

utilizes is in conflict with OBI use. Please see previous discussion. Yes to your question. Shall we use another label?

@wdduncan
Copy link
Collaborator Author

Yes. I am aware of the other discussion. Right now, utilizes is still obsolete in OBI. So, there isn't a conflict. I made a number of label suggestions. What label do you prefer?

@linikujp
Copy link

I like "device utilizes material" this is very straight forward. It was endorsed by Bjoern as well.

@linikujp
Copy link

linikujp commented May 2, 2022

@wdduncan can we finalize with creating this relation in RO? After the creation, this ticket can be closed.
Thanks,
Asiyah

@wdduncan
Copy link
Collaborator Author

wdduncan commented May 2, 2022

@linikujp Do you have an ORCID?

@linikujp
Copy link

linikujp commented May 2, 2022

Yes. It is 0000-0003-2620-0345

@wdduncan
Copy link
Collaborator Author

wdduncan commented May 2, 2022

Thanks. I'll use your ORCID as the value in term editor. That seems to be preferred now.

@wdduncan
Copy link
Collaborator Author

wdduncan commented May 2, 2022

@linikujp See this PR.

@linikujp
Copy link

linikujp commented May 2, 2022

Thank you! That's great. When will it be ready to use?

@wdduncan
Copy link
Collaborator Author

wdduncan commented May 2, 2022

@linikujp Let's wait for the PR be approved.

@wdduncan wdduncan closed this as completed May 2, 2022
@wdduncan
Copy link
Collaborator Author

wdduncan commented May 3, 2022

@linikujp The relation device utilizes material has been added to ro-edit.owl. It will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants