Skip to content
This repository has been archived by the owner on Feb 14, 2020. It is now read-only.

Previous site to get IP info has moved #80

Open
ericandre615 opened this issue Sep 7, 2018 · 2 comments
Open

Previous site to get IP info has moved #80

ericandre615 opened this issue Sep 7, 2018 · 2 comments

Comments

@ericandre615
Copy link

Apparently the URL used to get ip info https://4.ifcfg.me/ has moved and my console outputs html. Would it be possible to check if a call to an external service/url fails then display a default or something more meaningful rather than a bunch of random html?

screen shot 2018-09-07 at 9 10 56 am

@d3mash
Copy link

d3mash commented Sep 8, 2018

i cloned the repo and made a little fix to this, can you possibly check it out? how do I get permission to push a new branch to origin?

@djbeadle
Copy link

djbeadle commented Sep 9, 2018

@d3mash I'm not a maintainer on this project, but I'm chiming in because I just noticed the issue. The best thing to do is to fork the repo on the Github website (Not a real fork, but it creates a duplicate repo that you have full permissions to), commit your changes to that, and then open a pull request on Github.

This page details the process: https://help.github.com/articles/creating-a-pull-request-from-a-fork

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants