Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Headers on api defaults #555

Open
Xiphe opened this issue Jan 15, 2024 · 0 comments
Open

support Headers on api defaults #555

Xiphe opened this issue Jan 15, 2024 · 0 comments

Comments

@Xiphe
Copy link
Collaborator

Xiphe commented Jan 15, 2024

as with #538, oazapfts uses Headers internally instead of a plain object.

Initially we expanded this also to the defaults but it turned out that by this one would need to typecheck if defaults.headers is an object or of type Headers before setting to it.

To fix #551 we rolled back to only allow CustomHeaders on Defaults

In the future we might want to add a feature flag to opt into having a Headers object pre-set on the defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant