Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to oauthlib community #511

Closed
4 of 5 tasks
JonathanHuot opened this issue Jan 28, 2018 · 10 comments
Closed
4 of 5 tasks

Migration to oauthlib community #511

JonathanHuot opened this issue Jan 28, 2018 · 10 comments

Comments

@JonathanHuot
Copy link
Member

JonathanHuot commented Jan 28, 2018

Hi everyone,

Since @idan accepted the oauthlib community migration, as a team, we should list what do we need to progress as a true community. I suggest to start with a small list, and please anyone, feel free to participate by adding any suggestions :-)

Define/Improve release process:

Future, roadmap:

  • : Do periodic bugs washes could be beneficial

Also, a quick round table could be great. I start the introductions, I'm currently working on a OAuth2.0 RequestValidator implementation with bottle, and I've never worked with OAuth1.0, nor Django nor Pyramid nor Flask. However, I'm trying to have a good knowledge around the RFC involved here (oauth2, introspect, revocation, jwt...). I have not started yet the OpenID integration, but it will come soon.

@skion
Copy link
Member

skion commented Feb 1, 2018

All great ideas @JonathanHuot!

And what do people think about:

  • Cleaning up some of the old branches.
  • Starting to use GitHub's milestones to plan releases (happy to make a first run on e.g. 3.0, 3.1, 4.0).
  • Planning to drop support for Python 2 in one of the major releases (4.0 perhaps).
  • Introducing type annotations (after having dropped Python 2).
  • Introducing a coding style.

@wiliamsouza
Copy link
Member

@JonathanHuot I'm trying clear things a little bit here #512

@duaneking
Copy link
Member

Anything I can do just ask.

@MattBlack85
Copy link
Contributor

chiming in :) while working on a PR I noticed there is no coding style around which makes things sometimes hard to follow. I'd like to work on that if you guys are ok. Maybe starting with a issue containing a proposal and after that being accepted, starting to 💅 the codebase?

@JonathanHuot
Copy link
Member Author

Hi @MattBlack85, it's a good idea, any work in this direction is welcomed ! :-)

@ViktorHaag
Copy link
Contributor

ViktorHaag commented Apr 4, 2018

re: coding style. I've found in projects I've worked on that by using autopep8 and yapf, I can basically let tooling clean up the coding style so I don't have to worry about it (except in cases where the cleaned up version is far less useful than having it un-cleaned-up, usually to do with line-lengths that would be clearer and only exceed the length boundary by a character or two). I use elpy-mode in Emacs to make that easy, but I suspect it could easily be done in command-line, and CI, as well.

Having an .editorconfig in the root of the repo has also been useful.

@skion
Copy link
Member

skion commented Apr 4, 2018

Just thinking we probably want to have a run merging the currently open PRs before passing the code through a formatter. I'm all for pep8/flake8/yapf.

@MattBlack85
Copy link
Contributor

👍

@duaneking
Copy link
Member

👍

I'm a big fan of just keeping things PEP8.

@JonathanHuot
Copy link
Member Author

If no objections, I declare this task done 🍾

The new community has released one patch 2.0.7 and one minor 2.1.0 releases and we're working toward a major 3.0.0 release.

Don't hesitate to chip in and participate to this new exciting release !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants