Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to properly sign release enclaves. #1707

Open
Yawning opened this issue May 14, 2019 · 4 comments
Open

Figure out how to properly sign release enclaves. #1707

Yawning opened this issue May 14, 2019 · 4 comments
Labels
c:build Category: build environment c:security Category: security issues p:1 Priority: core feature

Comments

@Yawning
Copy link
Contributor

Yawning commented May 14, 2019

At some point we need to start signing enclaves with our production SGX keys. This isn't too difficult in theory, however the fortanix tooling (sgxs-sign) does not support signatures with a HSM.

As it is unacceptable to be carting around our signing key as a PEM file, this likely will require extending the tooling or writing our own.

Estimated cost: 1 sprint

@Yawning Yawning added c:build Category: build environment p:1 Priority: core feature labels May 14, 2019
@Yawning
Copy link
Contributor Author

Yawning commented May 14, 2019

While we're here, we should explicity reject the MRSIGNER value 9affcfae47b848ec2caf1c49b4b283531e1cc425f93582b36806e52a43d78d1a (https://github.com/fortanix/rust-sgx/blob/master/enclave-runner/src/dummy.key).

For my future reference more than anything else MRSIGNER is derived from the SHA256 digest of the little endian representation of the modulus. Valid signing keys are always 3072 bit RSA keys, with the exponent set to 3.

@kostko kostko added the c:security Category: security issues label Aug 12, 2019
@kostko
Copy link
Member

kostko commented Dec 2, 2019

Related upstream issue is fortanix/rust-sgx#184.

@Yawning
Copy link
Contributor Author

Yawning commented May 14, 2020

The majority of the work required to support this has been done via #2893. The remaining concerns are primarily policy based, as the node will happily accept detached per-generated SIGSTRUCTs when instantiating enclaves.

@ravenac95
Copy link
Contributor

Added fortanix/rust-sgx#327 to support the ideal signing process.

@Yawning Yawning removed their assignment May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:build Category: build environment c:security Category: security issues p:1 Priority: core feature
Projects
None yet
Development

No branches or pull requests

3 participants