Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leapp upgrade --resume continues when error happens before #609

Open
pirat89 opened this issue Feb 15, 2020 · 0 comments
Open

leapp upgrade --resume continues when error happens before #609

pirat89 opened this issue Feb 15, 2020 · 0 comments
Labels

Comments

@pirat89
Copy link
Member

pirat89 commented Feb 15, 2020

Actual behavior
In case the execution is in the phase where leapp is expected to end (because a checkpoint is reached e.g.) AND an actor in this phase ends with error, the leapp upgrade --resume doesn't check the end of the previous run and continues with the next phase.

Note
We discovered that behaviour time ago but I do not see it report it anywhere. In case it is fixed, close the issue. It's possible that the issue can be seen in more cases than only the end of workflow because of reached checkpoint. To test the behaviour, try soething like (pseudocode):

modify an actor in specific phase which will raise an error, so workflow execution ends
leapp upgrade --debug
leapp upgrade --resume

Expected solution
The workflow execution stops because of the previous error.

@pirat89 pirat89 added the bug label Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant