Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absence of API to access leapp config from leapp-repository #531

Open
fernflower opened this issue Jun 21, 2019 · 2 comments
Open

Absence of API to access leapp config from leapp-repository #531

fernflower opened this issue Jun 21, 2019 · 2 comments
Labels
bug enhancement

Comments

@fernflower
Copy link
Member

We have moved leapp's configuration to config.py but it's a small step in a series of removing hardcoded values and actually making the configuration shared.

Hardcoded stuff in leapp-reporsitory example:
https://github.com/oamg/leapp-repository/blob/master/repos/system_upgrade/el7toel8/actors/verifycheckresults/actor.py#L26
@fernflower fernflower mentioned this issue Jun 21, 2019
Merged
@drehak
Copy link
Contributor

drehak commented Jun 24, 2019

I presumed that simply importing the config into e.g. an actor and then using its functions would be just fine, are there any problems?

@pirat89
Copy link
Member

pirat89 commented Jun 26, 2019

@drehak: This is more for API / stdlib to be able to access the data. Regarding the thing that actor contains already configuration, it doesn't seem as right solution to mix it up. If I understand your idea.

MichalHe pushed a commit to MichalHe/leapp that referenced this issue Aug 12, 2021
@zhukovgreen
Add actor localreposinhibit (oamg#531)
2113e66 
* Add localreposinhibit actor

The purpose is to inhibit the upgrade if the local repository
was found (which has baseurl starting with file:///).

The new model TMPTargetrepossitoriesFacts was introduced, due to the limitations
in UsedTargetRepositories and TargetRepositories models. The TMPTargetRepositoriesFacts
model is going to be deprecated starting Sep 1, 2020.

UsedTargetRepositories has only repoids data. TargetRepositories has baseurls of repos,
but not in all cases (i.e. urls are missing if the repo introduced inside the yum.repo.d dir).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fernflower @pirat89 @drehak