Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange error reporting #372

Open
AloisMahdal opened this issue Nov 7, 2018 · 1 comment
Open

Strange error reporting #372

AloisMahdal opened this issue Nov 7, 2018 · 1 comment

Comments

@AloisMahdal
Copy link
Contributor

After subscribing to RHSM and attempting leapp upgrade, the upgrade fails and reports errors. However:

  • the errors are reported to STDOUT, not STDERR along with other messages
  • there is some (possibly) stray output
  • the format of error messages is a bit inconsistent with the rest (eg. INFO, WARNING)
    • fractional part of second has more digits
    • the severity token has brackets, ie. [ERROR] instead of ERROR.

This makes log parsing a bit more work and/or less reliable.


command line:

leapp upgrade --debug --whitelist-experimental patchdnf

stdout:

1 local certificate has been deleted.
All local data refreshed


============================================================
                        ERRORS
============================================================

2018-11-07 17:08:46.880315 [ERROR] Actor: prepare_upgrade_transaction Message: Error: Cannot find even basic RHEL repositories.: It is required to have RHEL repository on the system provided by the subscription-manager. Possibly you are missing a valid SKU for the target system.
2018-11-07 17:08:48.122648 [ERROR] Actor: prepare_upgrade_transaction Message: Error: Cannot find even basic RHEL repositories.: It is required to have RHEL repository on the system provided by the subscription-manager. Possibly you are missing a valid SKU for the target system.

============================================================
                     END OF ERRORS
============================================================

stderr:

2018-11-07 18:08:04.505 INFO     PID: 16687 leapp: Logging has been initialized
2018-11-07 18:08:05.32  INFO     PID: 16687 leapp.repository.common: A new repository 'common' is initialized at /etc/leapp/repos.d/common
2018-11-07 18:08:05.441 INFO     PID: 16687 leapp.repository.containerization: A new repository 'containerization' is initialized at /etc/leapp/repos.d/containerization
2018-11-07 18:08:05.581 INFO     PID: 16687 leapp.repository.offline-upgrade: A new repository 'offline-upgrade' is initialized at /etc/leapp/repos.d/offline-upgrade
2018-11-07 18:08:05.765 INFO     PID: 16687 leapp.repository.upgrade: A new repository 'upgrade' is initialized at /etc/leapp/repos.d/upgrade
2018-11-07 18:08:05.976 INFO     PID: 16687 leapp.repository.oamg-qe: A new repository 'oamg-qe' is initialized at /etc/leapp/repos.d/oamg-qe
2018-11-07 18:08:07.45  WARNING  PID: 16731 leapp.linter: Actor <class 'actor.PrepareUpgradeTransaction'> field produces should be a tuple of Models
2018-11-07 18:08:07.575 INFO     PID: 16687 leapp.workflow: Starting workflow execution: InplaceUpgrade - ID: 1931867b-c312-4f6a-8fee-92eae7b15439
[...]
@tcerna
Copy link

tcerna commented Dec 7, 2018

Hi, this problem is still current. Error in preupgrade_upgrade_transaction has appeared and exit code of leapp is 0. Standard exit code is 0 and any number from 1 to 255 for anything else. I would expect other exit status instead of 0 in case of error.

This caused in our automation, that it evaluates leapp processing as successful and indicates reboot for processing the upgrade.

MichalHe pushed a commit to MichalHe/leapp that referenced this issue Aug 12, 2021
There are PES events where one follows up on another. One is from 7.6 release to 8.0 and the other from 8.0 to 8.1. This commit makes sure these "chained" events are processed correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants