Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review: tiled example #1

Open
200sc opened this issue Aug 19, 2020 · 0 comments
Open

Code review: tiled example #1

200sc opened this issue Aug 19, 2020 · 0 comments

Comments

@200sc
Copy link
Contributor

200sc commented Aug 19, 2020

@Implausiblyfun

https://github.com/oakmound/oakgrove/blob/336cb450e10326eb83cbb90e0f6fe64a3c606c8e/code-examples/tiled-loader/maps/level.go#L45: This looks like a candidate for replacing with filepath.Clean

It looks like loadMaps should be deleted. Is it being used somewhere?

Otherwise, just run a linter and get rid of any yellow lines, and remove commented out code and it looks good to me.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@200sc