Overhaul UI #280
Open
Overhaul UI #280
+9,930
−3,922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution, I don't know if it makes sense to review this yet, since this and #278 clash and might create merge conflicts. I also am in favor of publishing the already working UI with #278 to EGO first, before doing this. And then testing it extensively and by multiple users, before releasing it. But overall it really looks good, so I'm going to look at this as soon as the issues and PR's with more priority are resolved. And just from glancing over it, there are a few things to do:
|
Totto16
requested changes
May 8, 2024
| @@ -7,7 +7,7 @@ | |||
| "scripts": { | |||
| "build": "yarn run build:ts && yarn run gen:locale && yarn run build:extension", | |||
| "gen:locale": "yarn run ts-node scripts/generateLocale.ts", | |||
| "build:ts": "yarn run clean:ts && rollup -c --failAfterWarnings && sed -i '/setTimeout/d' dist/thirdparty/prismjs.js && sed -i 's/var\\ /let\\ /g' dist/extension.js dist/prefs.js", | |||
| "build:ts": "yarn run clean:ts; rollup -c --failAfterWarnings && sed -i '/setTimeout/d' dist/thirdparty/prismjs.js && sed -i 's/var\\ /let\\ /g' dist/extension.js dist/prefs.js", | |||
There was a problem hiding this comment.
This is just here to block this from being merged for the moment, please leave this unresolved
Edit: sidenote @oae could you turn on, that we require at least one approval, before being able to merge, ty
boerdereinar
force-pushed
the
gnome-theming-v2
branch
from
5159092
to
101ea17
Compare
…le in build:ts + style changes clean:ts is now able to fail so that I can build Pano while it is still running
…ort incognito mode
…style in compact mode
boerdereinar
force-pushed
the
gnome-theming-v2
branch
from
101ea17
to
ff610a6
Compare
Can be triggered by: 1. Pressing the action button 2. Ctrl + click on the item 3. Ctrl + enter on the item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhaul UI
Description
This pr fully overhauls the UI as per #185.
New Features
/home/user/*are shortened to~/*Misc
yarn run clean:tscan now fail inbuild:tsto make building easier while pano is still runningDependencies
color-stringfor easy color parsing and conversion to rgbvalidate-colorhex-color-converterScreenshots
New UI
Compact Mode
Window Position: Pointer
Incognito Mode
Header Style: Compact
Fixes
Fixes #124
Fixes #150
Fixes #176
Fixes #185
Fixes #272
Type of change
Checklist