Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change el9 appliance to ship el9 based ovirt engine #94

Open
sandrobonazzola opened this issue Dec 6, 2022 · 5 comments
Open

Change el9 appliance to ship el9 based ovirt engine #94

sandrobonazzola opened this issue Dec 6, 2022 · 5 comments

Comments

@sandrobonazzola
Copy link
Member

Up to oVirt 4.5.4 the el9 appliance rpm was shipping a vm based on CentOS Stream 8.

For next release the appliance vm should be moved to CentOS Stream 9 so the solution will be fully based on that distribution.

@sandrobonazzola
Copy link
Member Author

Requires backport of #82 to ovirt-4.5 branch, @didib can you assist?

didib added a commit to didib/ovirt-appliance that referenced this issue Dec 15, 2022
This patch is not intended to be merged to master branch. Instead, it's
intended to be merged to a new 4.5 branch, replacing current ovirt-4.5,
which would be branched from current master.

It should represent all the intended differences between 4.5 and master.

The immediate reason is
oVirt#94 .

While working on cherry-picking the patches there to 4.5, I realized
there are many more patches in master not cherry-picked to 4.5, and at
least some of those I checked, made sense to also be in 4.5. So current
patch is an alternative to this pick-and-choose process.

Change-Id: Id6ba5fd06ef40e403a4e085aecfb64ec84b5056c
Signed-off-by: Yedidyah Bar David <didi@redhat.com>
didib added a commit to didib/ovirt-appliance that referenced this issue Dec 15, 2022
This patch is not intended to be merged to master branch. Instead, it's
intended to be merged to a new 4.5 branch, replacing current ovirt-4.5,
which would be branched from current master.

It should represent all the intended differences between 4.5 and master.

The immediate reason is
oVirt#94 .

While working on cherry-picking the patches there to 4.5, I realized
there are many more patches in master not cherry-picked to 4.5, and at
least some of those I checked, made sense to also be in 4.5. So current
patch is an alternative to this pick-and-choose process.

Notably missing is the differentiation between where to upload on
resources.ovirt.org - github-ci/ovirt-appliance or
github-ci/ovirt-appliance-4.5 . I do not fully understand the intended
use of each of them.

Change-Id: Id6ba5fd06ef40e403a4e085aecfb64ec84b5056c
Signed-off-by: Yedidyah Bar David <didi@redhat.com>
@didib
Copy link
Member

didib commented Dec 15, 2022

Requires backport of #82 to ovirt-4.5 branch, @didib can you assist?

Started looking at that, and it seems like both too much work and not enough - because we did many other things in master that we actually want in 4.5 as well. So instead I propose something like https://github.com/didib/ovirt-appliance/commits/new-4.5-branch .

@michalskrivanek
Copy link
Member

why would we need anything on 4.5 branch?can't we just move to 9 or am I missing the point?

didib added a commit to didib/ovirt-appliance that referenced this issue Dec 15, 2022
This patch is not intended to be merged to master branch. Instead, it's
intended to be merged to a new 4.5 branch, replacing current ovirt-4.5,
which would be branched from current master.

It should represent all the intended differences between 4.5 and master.

The immediate reason is
oVirt#94 .

While working on cherry-picking the patches there to 4.5, I realized
there are many more patches in master not cherry-picked to 4.5, and at
least some of those I checked, made sense to also be in 4.5. So current
patch is an alternative to this pick-and-choose process.

Change-Id: Id6ba5fd06ef40e403a4e085aecfb64ec84b5056c
Signed-off-by: Yedidyah Bar David <didi@redhat.com>
@didib
Copy link
Member

didib commented Dec 15, 2022

No idea - I do not fully understand the uses of master and 4.5 branches in this repo... @sandrobonazzola ?

@sandrobonazzola
Copy link
Member Author

master consumes nightly builds from copr master repo.

ovirt-4.5 branch consumes cbs builds from testing repo at release candidate time and from centos mirrors at final release time.

If the intention is to stop building for el8, yes we can just switch 4.5 branch to el9 instead of building both. @michalskrivanek what's the expectation for 4.5.5 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants