Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodemailer should be a production dependency #33

Open
brainomite opened this issue Aug 30, 2020 · 0 comments · May be fixed by #34
Open

nodemailer should be a production dependency #33

brainomite opened this issue Aug 30, 2020 · 0 comments · May be fixed by #34

Comments

@brainomite
Copy link

brainomite commented Aug 30, 2020 •
edited

On production servers where NODE_ENV=production nodemailer wasn't getting installed.
This presents a problem as the code requires nodemailer for the /api/alive route.

nodemailer is required here in mailTester.js.

mailTester.js itself is required here.

Last but not least, you can see nodemailer is a development dependency here.
@brainomite brainomite linked a pull request Aug 30, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make nodemailer a production dependency brainomite/Ad-Hoc-Email-Server
1 participant
@brainomite