Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal setcap requirement #238

Open
ouuan opened this issue Apr 20, 2024 · 0 comments
Open

Minimal setcap requirement #238

ouuan opened this issue Apr 20, 2024 · 0 comments

Comments

@ouuan
Copy link

ouuan commented Apr 20, 2024

Is your feature request related to a problem? Please describe.

Now nexttrace recommends cap_net_admin,cap_net_raw=eip for the entire binary. In contrast:

  • mtr and wireshark use dedicated binaries mtr-packet and dumpcap with capabilities, and the main binaries mtr and tshark have no capability.
  • mtr-packet only has cap_net_bind_service,cap_net_raw=ep, without cap_net_admin and the i flag.

Describe the solution you'd like

Require minimal capabilities that are necessarily needed by nexttrace to function. It will be better if the part that needs the capabilities is split into a separate binary.

Describe alternatives you've considered

The i flag is already not checked. We can just set cap_net_admin,cap_net_raw=ep and will not get warnings.

If only cap_net_raw=ep is set, there will be a warning, but it seems that nexttrace still functions well.

Additional context

There is a similar concern at https://aur.archlinux.org/packages/nexttrace#comment-965309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant