[BUG] check-module-boundaries.js adds significant time to test workflows #841
Labels
Comments
Tungsten78
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behavior
There is considerable overhead added to TDD style dev/test workflows (most often using VS Test Explorer):
Context:
We are enforcing module boundaries using the .eslintrc.json fallback (unified config for all projects).
It appears the bulk of the execution time is with the .eslintrc.json fallback
nx test {project} --filter FIND_NOTHING --skip-nx-cacheNote: related to #829
Expected Behavior
Boundaries checks should not interfere with test workflows (expect little to no overhead).
Github Repo
No response
Steps to Reproduce
Nx Report
nx.json
{ "plugins": ["@nx-dotnet/core", "@nxlv/python", "@nx-tools/nx-container"], "workspaceLayout": { "projectNameAndRootFormat": "derived", "appsDir": "apps", "libsDir": "libs" }, "namedInputs": { "default": ["{projectRoot}/**/*", "sharedGlobals"], "production": [ "default", "!{projectRoot}/**/?(*.)+(spec|test).[jt]s?(x)?(.snap)", "!{projectRoot}/tsconfig.spec.json", "!{projectRoot}/jest.config.[jt]s", "!{projectRoot}/.eslintrc.json", "!{projectRoot}/cypress/**/*", "!{projectRoot}/**/*.cy.[jt]s?(x)", "!{projectRoot}/cypress.config.[jt]s", "!{projectRoot}/src/test-setup.[jt]s" ], "sharedGlobals": [] }, "targetDefaults": { "serve": { "dependsOn": ["codegen", "^codegen"], "inputs": ["production", "^production"] }, "build": { "dependsOn": ["^build", "codegen", "^codegen"], "inputs": ["production", "^production"], "cache": true }, "component-test": { "inputs": ["default", "^production"], "outputs": ["{projectRoot}/cypress/results"], "cache": true }, "test": { "inputs": ["default", "^production", "{workspaceRoot}/jest.preset.js"], "outputs": [ "{projectRoot}/junit.xml", "{projectRoot}/test-results.xml", "{workspaceRoot}/coverage/{projectRoot}" ], "cache": true }, "e2e": { "inputs": ["default", "^production"], "outputs": ["{projectRoot}/cypress/results"], "cache": true }, "@nx-dotnet/core:build": { "dependsOn": ["^build", "codegen", "^codegen"], "inputs": [ "default", "production", "^production", "{workspaceRoot}/.eslintrc.json", "{workspaceRoot}/Directory.Build.props", "{workspaceRoot}/Directory.Build.targets", "{workspaceRoot}/Directory.Packages.props" ], "cache": true }, "@nx-dotnet/core:test": { "inputs": [ "default", "^production", "{workspaceRoot}/.eslintrc.json", "{workspaceRoot}/Directory.Build.props", "{workspaceRoot}/Directory.Build.targets", "{workspaceRoot}/Directory.Packages.props" ], "outputs": ["{projectRoot}/TestResults"], "cache": true }, "@nxlv/python:build": { "options": { "outputPath": "{workspaceRoot}/dist/{projectRoot}" } }, "publish": { "cache": true }, "lint": { "cache": true }, "swagger": { "cache": true }, "codegen": { "cache": true }, "preview": { "cache": true }, "@nx/jest:jest": { "inputs": ["default", "^production", "{workspaceRoot}/jest.preset.js"], "outputs": [ "{projectRoot}/junit.xml", "{projectRoot}/test-results.xml", "{workspaceRoot}/coverage/{projectRoot}" ], "cache": true, "options": { "passWithNoTests": true }, "configurations": { "ci": { "ci": true, "codeCoverage": true } } } }, "affected": { "defaultBase": "master" }, "generators": { "@nx-dotnet/core:application": { "language": "C#", "template": "webapi", "testTemplate": "xunit", "tags": "type:app" }, "@nx-dotnet/core:library": { "language": "C#", "template": "classlib", "testTemplate": "xunit" }, "@nx/angular:application": { "style": "scss", "linter": "eslint", "unitTestRunner": "jest", "e2eTestRunner": "none", "addTailwind": true, "standalone": true, "inlineTemplate": true, "inlineStyle": true, "skipTests": true, "tags": "type:app" }, "@nx/angular:library": { "linter": "eslint", "unitTestRunner": "jest", "style": "scss", "skipModule": true, "standalone": true, "inlineTemplate": true, "inlineStyle": true, "skipTests": true }, "@nx/angular:component": { "style": "scss", "standalone": true, "changeDetection": "OnPush", "inlineTemplate": true, "inlineStyle": true, "flat": true, "skipTests": true } }, "nxCloudAccessToken": "REDACTED", "parallel": 3 }Failure Logs
Additional Information
No response
The text was updated successfully, but these errors were encountered: