Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Replace Swashbuckle.AspNetCore with NSwag #819

Open
sharky98 opened this issue Jan 18, 2024 · 3 comments
Open

[Feature] Replace Swashbuckle.AspNetCore with NSwag #819

sharky98 opened this issue Jan 18, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed scope: core

Comments

@sharky98
Copy link

Is your feature request related to a problem? Please describe.
Swashbuckle.AspNetCore has not been touched for over a year now and does not support .NET 8.0. Even the official docs were updated to flag this issue.

Describe the solution you'd like
There seems to be an alternative that is actively maintained, NSwag. The solution would be to update @nx-dotnet to use NSwag (or allow it under some configuration/flag) instead of Swashbuckle.AspNetCore

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@sharky98 sharky98 added enhancement New feature or request needs-triage This issue has yet to be looked over by a core team member labels Jan 18, 2024
@nithinbandaru1
Copy link

Hi just came accross this. You should add it in https://github.com/dotnet/aspnetcore according to https://github.com/dotnet/templates?tab=readme-ov-file

@AgentEnder
Copy link
Member

I'd be open to a PR to handle this in our generators, but I don't have time to invest to do it myself right now.

@AgentEnder AgentEnder added help wanted Extra attention is needed good first issue Good for newcomers scope: core and removed needs-triage This issue has yet to be looked over by a core team member labels Jan 27, 2024
@sharky98
Copy link
Author

@nithinbandaru1 I agree the template themselves should be managed by the dotnet templates directly. I was thinking more about the generators that uses the swagger command line. So I think this affect those: @nx-dotnet/core:swagger-typescript, @nx-dotnet/core:update-swagger, @nx-dotnet/core:add-swagger-target and @nx-dotnet/core:openapi-codegen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed scope: core
Projects
None yet
Development

No branches or pull requests

3 participants