Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalNWBin failed only with NW2 (with my app) [demo video included] #7547

Open
josh83abc opened this issue Aug 17, 2020 · 5 comments
Open

evalNWBin failed only with NW2 (with my app) [demo video included] #7547

josh83abc opened this issue Aug 17, 2020 · 5 comments
Labels

Comments

@josh83abc
Copy link

josh83abc commented Aug 17, 2020

Hello Roger!

Following this issue that you closed (#7331), I bring more info now.

I have updated my app recently with the latest NWJS (47.2) and I saw that I still get an error while loading my V8 snapshot with NW2! It only works with NW1 but since you plan to remove it, I have a problem :D

Error handling response: TypeError: Cannot read property 'createElement' of undefined
at anonymous()
at anonymous()
at anonymous()
at anonymous()
at anonymous()
at NWWindow.evalNWBinInternal (extensions::nw.Window:472:20)
at NWWindow.evalNWBin (extensions::nw.Window:453:8)
at chrome-extension://jklhobfmppcchocjfekhndilpodhlnob/release/background.js:4:6
at extensions::nw.Window:799:13

I made a video to show the problem here : https://you.dj/evalbin_nw2_bug.mp4

Also here is the test project used in the video : https://you.dj/evalbin_nw2_bug.zip

Image of the error : https://you.dj/evalbin_nw2_bug.png

As I said in the video, I tried to do a simple code snippet but I didn't get this error. The error is only with with my app. Since my app code is quite large, it is hard to identify the line of code which triggers the evalnwbin error, but I assume you can debug better than me.

Thanks a lot!

@josh83abc
Copy link
Author

Pin to Remove NW1 mode #7230

@rogerwang
Copy link
Member

I'm trying to reproduce this with your sample. How did you got myscript.bin? Can you provide the source code of it?

@rogerwang
Copy link
Member

close until more information is available.

@josh83abc
Copy link
Author

josh83abc commented Oct 10, 2020

Hello Roger! sorry I didn't see your question in time, please don't close my point for the second time haha :)

Have you been able to reproduce the problem? What does the crash trace says?

myscript.bin is... well my app javascript code that I compiled with NWJC. Here is the code of the app : https://you.dj/myscript.js, which is also a webapp that you can have access here : https://you.dj

It is plain vanilla javascript, no asm.js or wasm but I am using web workers. Also it is pretty small (600kB)

ps : all names of the variables/functions are obfucated because it is not an "open source" app
my personal email : erik@you.dj

@rogerwang rogerwang reopened this Oct 11, 2020
@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2022
@stale stale bot removed the stale label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants