Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nw2: close event on Window is not firing if you open remote url #7503

Closed
hrocha1 opened this issue Jun 10, 2020 · 5 comments
Closed

nw2: close event on Window is not firing if you open remote url #7503

hrocha1 opened this issue Jun 10, 2020 · 5 comments
Assignees
@rogerwang

Comments

@hrocha1
Copy link

hrocha1 commented Jun 10, 2020 •
edited

NWJS Version : nwjs-sdk-v0.46.2-win-ia32
Operating System : Windows 10

Expected behavior

Close event should happen while closing a window no matter if it's content is local file or remote url.

Actual behavior

Close event is emitted only when closing a window with local file.

This problem happens only with nw2 mode enable. It works correctly with --disable-features=nw2 switch.

How to reproduce

Download the attached file, extract it and run nw.exe against the issue10 directory.

issue10.zip
@rogerwang
Copy link
Member

CC #7230

@rogerwang rogerwang self-assigned this Jun 10, 2020
hrocha1 pushed a commit to hrocha1/nw.js that referenced this issue Jun 13, 2020
[test] add test for nwjs#7503
6725047
@hrocha1 hrocha1 mentioned this issue Jun 13, 2020
Merged
@hrocha1
Copy link
Author

hrocha1 commented Jun 13, 2020

I've made a test for this issue, hope that helps.

rogerwang added a commit that referenced this issue Jun 14, 2020
@rogerwang
src: Fix: nw2 close event on remote URL #7503
adc11cc 
nwjs/chromium.src@a869974
@rogerwang
Copy link
Member

I've made a test for this issue, hope that helps.

Thanks. That's very helpful. I'll look to review it.

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

rogerwang pushed a commit that referenced this issue Jun 14, 2020
@rogerwang
[test] add test for #7503
eabb61c
@hrocha1
Copy link
Author

hrocha1 commented Jun 14, 2020

The nightly build is passing both the NW.js test and our internal tests, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogerwang rogerwang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rogerwang @hrocha1