Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NW2] Right click options not working as expected (Reload app + Simulate browser restart) #7367

Closed
TheRealDannyyy opened this issue Feb 10, 2020 · 7 comments

Comments

@TheRealDannyyy
Copy link

TheRealDannyyy commented Feb 10, 2020

NWJS Version: Any since NW2 update
Operating System: Windows 10
Reproduction Project: nwjs-remote-preview.zip

Expected behavior

Clicking the right click option to reload app should reload the app and simulating a browser restart should also work as it did in NW1 (--disable-features=nw2).

Actual behavior

Both right click options seem to just open a new window instead of reloading.

How to reproduce

  1. Download and unzip reproduction example into NWjs folder
  2. Run nwjs and right click "Reload app" or "Simulate Browser Restart"
  3. Notice that expected behavior is not occurring
@TheRealDannyyy
Copy link
Author

Fix required before NW1 removal, tagging #7230

@rogerwang
Copy link
Member

Is this a duplicate of #7271 ?

@TheRealDannyyy
Copy link
Author

I guess so. Will test to see if it's fixed in the next build.

@rogerwang
Copy link
Member

I'm merging this issue with #7271. Please give update there. Thanks.

@TheRealDannyyy
Copy link
Author

@rogerwang This is still a problem in the latest version. Reloading or simulating a restart using the right click options just opens a new window. It's even worse now and results in NWjs running in the background after closing.

Request to re-open issue for further investigation.

@rogerwang rogerwang reopened this Feb 24, 2020
@rogerwang
Copy link
Member

I just tried your sample with the latest version and it works for me.

@TheRealDannyyy
Copy link
Author

Also seems to work for me. Maybe I tested the wrong version 4 days ago.
Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants