Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please sync with the latest node-gyp 5+ #133

Open
gpetrov opened this issue Sep 11, 2019 · 4 comments
Open

Please sync with the latest node-gyp 5+ #133

gpetrov opened this issue Sep 11, 2019 · 4 comments

Comments

@gpetrov
Copy link

gpetrov commented Sep 11, 2019

nw-gyp is running way behind the latest node-gyp 5+
a lot of new compiler options are unsupported for the latest node that is already integrated in nwjs.

Please make it up to date.
@gpetrov
Copy link
Author

gpetrov commented May 12, 2020

A great pull request is already posted for this #136
and it works all fine

maybe @rogerwang should just review and accept it?

@rogerwang
Copy link
Member

Thanks. I'll see to update it.

@panther7
Copy link

Hmm, any news?

@WJsjtu
Copy link

WJsjtu commented Jan 19, 2022

Anything new here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rogerwang @gpetrov @WJsjtu @panther7