Cannot compile sqlite3 on Windows against latest nwjs (0.39+) #130
Comments
|
I seem to be having the same issue. |
|
Do someone progress? |
This was referenced Aug 26, 2019
|
This is still an issue even with nwjs 0.41.0-beta1 - no native modules can be compiled. Really hope @rogerwang can solve it soon |
|
This problem is old over 3 months. I stop believing that he will ever solve it. |
|
After update to nw-gyp@3.6.4 we have new error. Log: |
|
Just hit the same wall https://github.com/mapbox/node-pre-gyp seems to be incompatible with the latest nw-gyp (didn't had troubles with nw-gyp 3.4.0) I'm trying to build nodegit and it requires nore-pre-gyp for building. |
|
just published 3.6.5 for the ia32 issue. |
|
Now, we can build var sqlite3 = require('sqlite3');
var db = new sqlite3.Database(':memory:');
// crashTested on 0.39.1 and 0.41.1 Example: nw-db-init.zip Build log from |
|
BTW, x64 works, but x86 not :-/ |
|
My modules build as well on x64 - but it takes 3x longer and the .node files are twice the size of the ones build with the MSVC tools. it does rain warnings like: also maybe building is slower as the parallel building is off: |
|
@rogerwang any progress with x86 build? |
This comment has been minimized.
This comment has been minimized.
|
serialport@8.0.3 Compile with nwjs x64 0.41.2 So, these errors are not related with this issue. Sorry. |
|
@panther7 x86 works for me. Could you share more details? |
|
Yes, build is successfully, but after use sqlite in nwjs, crash it. Btw: # 1)
npm i -g nw-gyp node-pre-gyp &&
npm i -g --production --vs2015 windows-build-tools &&
git clone https://github.com/mapbox/node-sqlite3.git &&
cd node-sqlite3
# now you must modify: https://github.com/rogerwang/node-sqlite3-nwtest/commit/de4f51bd95d6a5be068b2da9b24a4a0976a01399#diff-21e418851ae48f9b11907837add9e39a
nw-gyp configure --arch=ia32 --target=0.41.2 &&
nw-gyp build --arch=ia32 --target=0.41.2same like: # 2)
npm i -g nw-gyp node-pre-gyp &&
npm i -g --production --vs2015 windows-build-tools &&
mkdir _test_sqlite3 && cd _test_sqlite3 &&
npm i sqlite3 --build-from-source --runtime=node-webkit --target_arch=ia32 --target=0.41.2
# https://github.com/mapbox/node-sqlite3#building-for-node-webkitDemo in attachment: demo.zip |
|
Crash dump: Crashpad.zip |
|
I just found the crash is related clang optimization under ia32: if you build it with debug configuration (nw-gyp --debug) it works well. Changing |
|
@rogerwang Good job, but it isn't right solution. Do you have any idea, how fix compile it normaly (OptimizationFull && FavorSpeed)? |
|
It’s not. Just used to illustrate where the root cause is. The bug could be in clang or SQLite though. |
|
Maybe, try update to newer node-gyp, https://github.com/nodejs/node-gyp/blob/master/CHANGELOG.md |
|
@panther7 I don't think node-gyp version has anything to do with this. The root cause is pin pointed with the experiment shown above. |
|
Yeah, you have probably right. I think, that could you close this issue and write to readme about this problem, building for ia32 with --debug parameter, like:¨ |
|
I ran into a similar issue building node-hid. After tearing my hair out for hours focusing on Node-hid, and nwjs I was able to resolve the issue by updating my nw-gyp from 3.6.3 to 3.6.5. Teaches me to let my global packages go stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Original issue: TryGhost/node-sqlite3#1179
All works on 0.38.x and older.
node-sqlite: https://www.npmjs.com/package/sqlite3
Apps:
Log:
@rogerwang
The text was updated successfully, but these errors were encountered: