Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(run): add unref option #159

Merged
merged 1 commit into from May 19, 2024
Merged

feat(run): add unref option #159

merged 1 commit into from May 19, 2024

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Apr 27, 2024

Fixes: #70
Refs: nwjs/nw.js#7852

@ayushmanchhabra ayushmanchhabra marked this pull request as draft April 27, 2024 13:38
@ayushmanchhabra
Copy link
Collaborator Author

ayushmanchhabra commented Apr 27, 2024

I have noticed that using unref() does not lead to zombie processes. But this also prevents blocking the caller.

Leaving this open so people can test and provide feedback.

@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review May 19, 2024 16:17
@ayushmanchhabra ayushmanchhabra changed the title feat: add unref option feat(run): add unref option May 19, 2024
@ayushmanchhabra ayushmanchhabra merged commit f772c0e into main May 19, 2024
3 checks passed
@ayushmanchhabra ayushmanchhabra deleted the dev-70 branch May 19, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminating nw Process by Ctrl+C Makes Its Children Zombies
1 participant