Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caching, multithreaded resumable downloads #18

Open
davidmarkclements opened this issue Apr 2, 2015 · 2 comments
Open

caching, multithreaded resumable downloads #18

davidmarkclements opened this issue Apr 2, 2015 · 2 comments

Comments

@davidmarkclements
Copy link

just pushed this: https://www.npmjs.com/package/install-nw

happy for you to take it and re-use if you think all or any part is appropriate

@shama
Copy link
Contributor

shama commented Apr 2, 2015

Wow I think all of that is rad. Would you mind sending a PR for it?

@davidmarkclements
Copy link
Author

so... it depends how you want to use it,

because of code boundaries install-nw takes this approach:

  1. if zip is not in cache, download the zip and store in cache
  2. create http server that responds with the cached zip
  3. install nw, setting nwjs_urlbase to the temporary server

It also then has to wrangle with the nw package.json file,
(basically we have to make sure that if npm install is run in a folder where nw is already installed, that it doesn't run the postinstall script - because that will revert to default behaviour).

I can wrap nw-install around nw as a PR, OR we can go for a more integrated approach,
e.g. by removing the temporary server dependency, get rid of package.json dance

This second approach would probably lead to lot's of refactoring so I'd suggest that you
lead that one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants