Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to update the internal data #33

Open
eeholmes opened this issue Dec 14, 2022 · 1 comment
Open

Figure out how to update the internal data #33

eeholmes opened this issue Dec 14, 2022 · 1 comment
Assignees
Milestone

Comments

@eeholmes
Copy link
Member

rcax_updata_sysdata

Or when the user does the first rcax_hli call or rcax_table_query, rcax_tables is called and _rcax_tables data is created. Then for subsequent calls it checks if that exists. If so it uses it, if not it doesn't. Might need to delete it on detaching or check creation date.

@eeholmes eeholmes added this to the v2.0.0 milestone Dec 14, 2022
@eeholmes eeholmes self-assigned this Dec 14, 2022
@eeholmes
Copy link
Member Author

eeholmes commented Dec 14, 2022

can do with this

assignInNamespace("caxpops", "test", ns = "rCAX")

Steps:

  • Start with the colnames.
  • Remove rcax_table_cols which is only called in rcax_hli I think. replace with rcax_hli(..., type="colnames").
  • change what is saved for colnames. Right now it is using
      NOSA = nosa_xport_colnames,
      SAR = sar_xport_colnames,
      PNI = pni_xport_colnames,
      JuvOut = juvout_xport_colnames,
      PreSmolt = presmolt_xport_colnames,
      RperS = rpers_xport_colnames

and the _colnames is created by a hard copy in docs. Very fragile. Needs to ping the data base and save the needed variables once.

  • do same with caxpops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant