Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create navigation.keymap keys that use the include and define search features as fallback options #37

Open
k-times-c opened this issue Jun 15, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@k-times-c
Copy link

k-times-c commented Jun 15, 2022

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Hey! First off awesome plugin. Thank you for your ample contributions to the community, especially for treesitter/virtual-text/nvim-dap implementations to name a few topics.

My thought is that there are some "native" keymappings that may prove to be useful as fallback implementations for this plugin.

Describe the solution you'd like
A clear and concise description of what you want to happen.

the [d / ]d as well as the [i and ]i and their variants provide some what of an archaic version of find_definition and find_usages. (see the help for those keymappings for more detail). I think they a fallback key for go to definition and list definition where appropriate would be awesome be a great out of the box improvement for this plugin, as well as neovim.

find_usage_fallback or find all definition_fallback to lsp or the native vim mappings where it makes sense.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

This may cause some confusion for some people, especially those who aren't familiar with this feature, but I at least wanted to get a dialogue for this

I haven't take a good look at the codebase yet, but I don't imagine this being too difficult. I'd be keen to take on this work with a little help. But if you as the maintainer want to roll with it that's no problem!

Additional context
Add any other context or screenshots about the feature request here.

I think the idea of trying to use treesitter to augment the native key mapping where it makes sense. the define and include search/jumps are treesitter could implement.

there are other vim bindings like w c_I that could be utilized as well.

hope this makes sense

@k-times-c k-times-c added the enhancement New feature or request label Jun 15, 2022
@k-times-c k-times-c changed the title utilize the include and define search features as fallback options create navigation.keymap keys that use the include and define search features as fallback options Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant