Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] pin luarocks version / manage luarocks installation #336

Open
mrcjkb opened this issue May 16, 2024 · 0 comments · May be fixed by #340
Open

[Enhancement] pin luarocks version / manage luarocks installation #336

mrcjkb opened this issue May 16, 2024 · 0 comments · May be fixed by #340
Labels
enhancement New feature or request

Comments

@mrcjkb
Copy link
Member

mrcjkb commented May 16, 2024

Our installer currently builds luarocks from source (HEAD), which could be bad if something breaks.
It would be better for us to pin the version.

We could add a CI workflow that updates the pinned version and auto-merges if our checks succeed (we have enough test coverage to do that now).

Another idea would be for the installer to install luarocks into a temp directory (or to use the system installation if detected)
and for rocks.nvim to add luarocks to its dependencies.
This needs to be investigated and tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant