Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QOL] sync should prune all rocks that can be pruned in one sweep #77

Closed
mrcjkb opened this issue Dec 11, 2023 · 0 comments · Fixed by #305
Closed

[QOL] sync should prune all rocks that can be pruned in one sweep #77

mrcjkb opened this issue Dec 11, 2023 · 0 comments · Fixed by #305
Assignees
Labels
enhancement New feature or request

Comments

@mrcjkb
Copy link
Member

mrcjkb commented Dec 11, 2023

It takes multiple sweeps.

Example:

  • Install haskell-snippets.nvim and luasnip
  • Delete them from rocks.toml
  • Rocks sync

Expected behaviour:

  • Both plugins, as well as the jsregexp dependency are pruned

Actual behaviour:

  • Only haskell-snippets.nvim is pruned. luasnip can't be pruned yet, if haskell-snippets.nvim isn't pruned first, because it depends on it.
  • It takes more than one call to Rocks sync to actually prune all dependencies.

Potential solutions:

  • Analyze dependencies, then figure out the order in which to prune rocks.
  • repeat <pruning logic> until <no more rocks that depend on installed rocks left in to_prune list>.
@mrcjkb mrcjkb self-assigned this Dec 11, 2023
@mrcjkb mrcjkb added the enhancement New feature or request label Dec 11, 2023
@mrcjkb mrcjkb changed the title [QOL] sync doesn't prune all rocks that can be pruned in one sweep [QOL] sync should prune all rocks that can be pruned in one sweep Dec 11, 2023
@mrcjkb mrcjkb pinned this issue Apr 29, 2024
@mrcjkb mrcjkb unpinned this issue Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant