Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] support pinning dependencies #34

Open
NTBBloodbath opened this issue Nov 28, 2023 · 2 comments · May be fixed by #244
Open

[Feature] support pinning dependencies #34

NTBBloodbath opened this issue Nov 28, 2023 · 2 comments · May be fixed by #244
Assignees
@mrcjkb
Labels
enhancement New feature or request

Comments

@NTBBloodbath
Copy link
Member

I think it would be very useful to support a lockfile to always install the plugins and their dependencies with the same version if you have to change the Neovim installation either because you installed your dotfiles on another machine or another reason.

Luarocks supports this natively, please take a look at Pinning versions with a lock file.
@NTBBloodbath NTBBloodbath added the enhancement New feature or request label Nov 28, 2023
@mrcjkb mrcjkb changed the title Feature request: support pinning [Feature] support pinning dependencies Dec 11, 2023
@mrcjkb
Copy link
Member

mrcjkb commented Dec 11, 2023

Perhaps we could incorporate the luarocks lock file into a section in rocks.toml:

[pinned-dependencies]
jsregexp = "0.0.6"

so that users don't have to maintain two files in scm.

@mrcjkb mrcjkb pinned this issue Dec 11, 2023
@mrcjkb mrcjkb linked a pull request Apr 5, 2024 that will close this issue
Draft
@mrcjkb mrcjkb self-assigned this Apr 7, 2024
@mrcjkb
Copy link
Member

mrcjkb commented Apr 7, 2024

Perhaps we could incorporate the luarocks lock file into a section in rocks.toml:

[pinned-dependencies]
jsregexp = "0.0.6"

so that users don't have to maintain two files in scm.

Scrapping this idea, because I'd prefer to keep rocks.toml as clean as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrcjkb mrcjkb

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: lockfile support nvim-neorocks/rocks.nvim
2 participants
@mrcjkb @NTBBloodbath