Right aligned status icons merged to main!

[cseickel]

This is something I've wanted from the beginning and I finally made it happen. With the new container support feature that I just merged to main, we now have right aligned diagnostic and git status icons. This also means that if there is not enough space, those icons will overlay the file name.

Even better, when a file name is truncated the last three characters will now fade out to indicate that. This is my favorite part.

Neo-tree.container.character.fading.mp4

If you have configured custom renderers, you will need to copy the new container component config from the default config to take advantage of this.

I made one change to the default values, which is to remove the default staged/upstaged symbols from the git status component. I think it looks better that way because it keeps that component to a one character symbol all the time.

I'm going to let this sit in main for a few days to see if there are any issues. If you try it out, please provide feedback!

[gegoune]

Is that circle suppose to change somehow indicating staged/unstaged changes made to buffer?

[gegoune]

I think that staged/unstaged could be bundled with modified, in a sense that in VCS' modified means unstaged unless it get staged so I probably would like to only see if file has staged changes or not (which would imply modified). That makes modified redundant, doesn't it? Or am I missing/misunderstanding anything here?

Edit: ah, of course modified means 'unsaved changes'. I think locally I will restore staged/unstaged icons.

[cseickel]

This should have been a reply instead of a new "answer", moving it here now:

It's mostly redundant. In the context of the filesystem source, a file may be either added (+) or modified (*), so that's the extra information that is lost by only using the status symbols.

In the context of the git_status source, there is also the additional deleted and renamed changed types that could show.

To be clear, it does not mean unsaved changes in the context of whether the changes have been saved to disk. These symbols are only for the git status.

[cseickel]

It sounds to me like you would be in favor of my second screenshot using only the status symbols, would you agree with that?

I guess one more variation, which is not currently supported, is to show modified(*)/added(+) only if it is unstaged, and only the staged symbol (checkbox) if it is staged.

[gegoune]

Another option would be to maybe just display icons for each case? What if file is partially staged, modified and unsaved? :) I think there is many combinations and as much as I would like to help I am not sure if I hare enough insight to influence you in any way (worried my reasoning might be flowed). With that said, I like information and in theory wouldn't mind having all states covered. Perhaps type of icon would be locked to its column? There could be gaps between icons but scanning to see what's up should be pretty easy.

[cseickel]

With that said, I like information and in theory wouldn't mind having all states covered. Perhaps type of icon would be locked to its column? There could be gaps between icons but scanning to see what's up should be pretty easy.

Now that's a good idea, and totally doable as a personal configuration change within what is deployed now. Maybe I will add a wiki page with screenshots and config example for all of these scenarios. I should also add a component to show if a file has unsaved changes.

I still need to figure out a sane default... maybe it's best to just revert the defaults to what it was in the last release.

[nyngwang]

@cseickel:

Where should I put the config to achieve the effect of the title? Sorry I didn't follow this thread the moment you were discussing it...

---

update: I just made it works by putting configs in filesystem.renderers.file/directory.

The question follows this is: It seems that

1. The usage of 'container' is not documented in the README.md
2. The renderers can be moved outside of filesystem, but I don't know the reasoning. The one you used here seems to be the latest syntax, right?

[cseickel]

That is the default config, so if you are having any trouble just remove your overrides or copy from defaults.lua and make whatever changes you need from that base.

1. The usage of 'container' is not documented in the README.md

The README is not the documentation, it is just the highlights for new users that have not installed the plugin yet. You should use the vim help file as your reference:

:h neo-tree-container

2. The renderers can be moved outside of filesystem, but I don't know the reasoning. The one you used here seems to be the latest syntax, right?

There are two other sources and more coming eventually. Putting renderers at teh global level allows you to define it once for all sources instead of having to repeat it for each one. The same applies to the window section.

This does look like the final syntax.