From 5490c43f729eee60f07920bf88c0aabdc1398b6e Mon Sep 17 00:00:00 2001 From: Daniel Roe Date: Tue, 11 Apr 2023 11:12:12 +0100 Subject: [PATCH] fix: do not expose token in public runtime config (#41) * fix: do not expose token in public runtime config * fix: remove formatting change * refactor: avoid setting token in first place --- src/module.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/module.ts b/src/module.ts index 0904660..f569f7e 100644 --- a/src/module.ts +++ b/src/module.ts @@ -69,7 +69,6 @@ export default defineNuxtModule({ owner: options.owner || process.env.GITHUB_OWNER, branch: options.branch || process.env.GITHUB_BRANCH, repo: options.repo || process.env.GITHUB_REPO, - token: options.token || process.env.GITHUB_TOKEN, disableCache: options.disableCache, parseContents: options.parseContents, maxContributors: options.maxContributors @@ -79,7 +78,9 @@ export default defineNuxtModule({ // @ts-ignore nuxt.options.runtimeConfig.public.github = defu(nuxt.options.runtimeConfig.public.github, config) // @ts-ignore - nuxt.options.runtimeConfig.github = defu(nuxt.options.runtimeConfig.github, config) + nuxt.options.runtimeConfig.github = defu(nuxt.options.runtimeConfig.github, { + token: options.token || process.env.GITHUB_TOKEN + }, config) // Autolink issue/PR/commit links using `remark-github` plugin if (options.remarkPlugin) {