Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Components] alt attribute support for gallery images #124

Open
ennioVisco opened this issue Apr 13, 2023 · 3 comments
Open

[Components] alt attribute support for gallery images #124

ennioVisco opened this issue Apr 13, 2023 · 3 comments

Comments

@ennioVisco
Copy link

The gallery component is quite nice, but it currently doesn't comply with standard HTML requirements (specifically, it does not forward alt attributes to the NuxtImg component: https://github.com/nuxt-themes/alpine/blob/main/components/content/Gallery.vue

Copy link
Contributor

Atinux commented Apr 13, 2023

Good catch, happy to open a PR @ennioVisco ?

@ennioVisco
Copy link
Author

ennioVisco commented Apr 13, 2023

Good catch, happy to open a PR @ennioVisco ?

I was trying but it's not very easy, if you can guide me in the process, I'd be happy to :)

I'm not sure about the correct strategy... I believe the best thing would be to wrap the input in a ProseImg instead of a NuxtImg, to make the DX in line with other images throughout the nuxt-content components.
However, I cannot understand how to transform a markdown-valid string into a <Prose*/> component with the current composables :/

Copy link
Contributor

Tahul commented May 17, 2023

@bdrtsky wdyt? :)

@Tahul Tahul changed the title Add alt attribute support for gallery images [Components] alt attribute support for gallery images May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants