Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scraper should issue warning when an individual lesson slot has duplicated weeks #3687

Open
kokrui opened this issue Mar 27, 2024 · 0 comments

Comments

@kokrui
Copy link
Member

kokrui commented Mar 27, 2024

In #3648, we notice that this year's data for ST2334 has individual lecture lesson slots (timetable entries) with duplicated weeks.

"weeks": [1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8, 8, 9, 9, 10, 10, 11, 11, 12, 12, 13, 13],

I presume that the intention is to create 2 lecture slots (which they did, but this bug remained), since it doesn't make sense for a timetable entry to occur in both week 1 and week 1 at the same time.

While we now hide these mistakes in the frontend through #3677, we should have the scraper produce a warning for when duplicated weeks appear in the weeks attribute of a timetable entry, so we can let the relevant departments know (especially if it's a systematic issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant