Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve module search page's exam clash detection #3663

Open
kokrui opened this issue Mar 10, 2024 · 0 comments · May be fixed by #3678
Open

Improve module search page's exam clash detection #3663

kokrui opened this issue Mar 10, 2024 · 0 comments · May be fixed by #3678

Comments

@kokrui
Copy link
Member

kokrui commented Mar 10, 2024

In #3560, we improved our exam clash detection algorithm. Previously, we only checked for exam start times, but it's possible that an exam's end time overlaps with another exam's start time.

However, the "No Exam Clash (Sem X)" filters in our Module Search page still use the previous detection method. We should change it to the better exam clash detection algorithm.

function getExamClashFilter(semester: Semester, examDates: string[]): FilterItem {

This will require some elasticsearch-fu. Relevant docs: https://www.elastic.co/guide/en/elasticsearch/reference/8.12/query-dsl-range-query.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant