Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPEx Tech Debt - Remove generation of MPE modules from NUSMods scraper #3625

Open
chrisgzf opened this issue Oct 1, 2023 · 0 comments
Open

CPEx Tech Debt - Remove generation of MPE modules from NUSMods scraper #3625

chrisgzf opened this issue Oct 1, 2023 · 0 comments
Assignees
@kokrui
Labels
better engineering

Comments

@chrisgzf
Copy link
Member

chrisgzf commented Oct 1, 2023

After #3622, we now have a dedicated MPE scraper.

NUSMods scraper no longer needs to read and generate the mpeModules.json file. We should remove the parts of NUSMods scraper that generates that file.
@chrisgzf chrisgzf changed the title CPE Tech Debt - Remove generation of MPE modules from NUSMods scraper CPEx Tech Debt - Remove generation of MPE modules from NUSMods scraper Oct 1, 2023
@chrisgzf chrisgzf mentioned this issue Oct 14, 2023
Merged
@kokrui kokrui self-assigned this Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kokrui kokrui

Labels
better engineering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrisgzf @ravern @kokrui