Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timetable share URL is no longer shortened #2057

Open
taneliang opened this issue Aug 12, 2019 · 3 comments · May be fixed by #3367
Open

Timetable share URL is no longer shortened #2057

taneliang opened this issue Aug 12, 2019 · 3 comments · May be fixed by #3367

Comments

@taneliang
Copy link
Member

taneliang commented Aug 12, 2019

Describe the bug

image

The URL should've been shortened to something like https://modsn.us/<somehash>.

Cause

We have a short_url.php script which mediates requests to our modsn.us URL shortener service. This was previously supported by Nginx. However, as #1937 changes the reverse proxy to Traefik, we need to add back PHP support for this to work again.

Possible actions

  1. Rewrite the script to not use PHP (done: Fix modsn.us URL shortening script #3212)
  2. Add fastcgi support to our Traefik reverse proxy. No longer needed as we've migrated away from Docker (Migrate /website and /export from Docker to Vercel #3098)
  3. Because the script takes a while to load, we need to improve the shortening UX by changing the UI (for context, see Fix modsn.us URL shortening script #3212):
    • Display the long URL while shortening happens
    • Display shortened URL once it's available
    • Allow toggling between original and shortened URLs so that 3rd party clients can use the URL without resolving the shortened URL. To be clear, parsing the share URL is not something we want to commit to supporting long-term, but let's just support it while it's convenient until we find a better way (e.g. with timetable sync: User accounts #796)
    • Or implement any variation that makes sense
    • Remove enableShortUrl feature flag once done.
@taneliang taneliang added the bug label Aug 12, 2019
@li-kai li-kai mentioned this issue Aug 12, 2019
4 tasks
@angelsl
Copy link
Contributor

angelsl commented Sep 12, 2019

Oh, it's a bug...

I actually liked it.

@li-kai
Copy link
Member

li-kai commented Sep 13, 2019

@angelsl I'm interested in why you like it. Could you explain a little why you prefer the long url?

@angelsl
Copy link
Contributor

angelsl commented Sep 13, 2019

@li-kai Sometimes I want to merge multiple timetables into one, etc; the long URL lets me do that easily.

Also saving the long URL gives me a bit more security since the information is there, versus the shortened URL where if the server dies my timetable would be lost.

I mean I could just resolve the shortened URL, but it's always one more step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants