Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add previews of all themes #339

Open
aidalgol opened this issue Jan 10, 2023 · 11 comments
Open

Add previews of all themes #339

aidalgol opened this issue Jan 10, 2023 · 11 comments

Comments

@aidalgol
Copy link

Could we add preview screenshots of the themes similar to how the Helix editor provides preview for its themes?

@fdncred
Copy link
Collaborator

fdncred commented Jan 10, 2023

Sure. Go for it. It would be cool to have a readme in that folder that has screenshots of all the themes that have been provided.

@aidalgol
Copy link
Author

What should I include in the screenshots to show the various theme colours? Maybe just the same ls command example on the Nushell website?
nushell screenshot

@fdncred
Copy link
Collaborator

fdncred commented Jan 11, 2023

I think the key is to have something that shows off the theme best. I'm fine with what you've suggested for now. However, it would be nice to have a script in the repo that generates this readme. If there was a script, it should be pretty easy to change whatever the output is.

@aidalgol
Copy link
Author

I'm going to try figuring out how asciinema does this for video to see whether that would be feasible for automating this.

@amtoine
Copy link
Member

amtoine commented Jan 12, 2023

I'm going to try figuring out how asciinema does this for video to see whether that would be feasible for automating this.

you could also probably automate screenshot taking with a script which would, for each theme available in themes/themes/, do the following

  • source the theme
  • run some command to have an overview of the color palette
  • take a screenshot
  • save it under the right path and with the right name

and finally update the README to preview all the themes 😋

@aidalgol
Copy link
Author

That would work, but it seems less reliable. Especially as I am on a tabbed window-manager.

@amtoine
Copy link
Member

amtoine commented Jan 13, 2023

That would work, but it seems less reliable. Especially as I am on a tabbed window-manager.

mm 🤔
you should be able to make a screenshot of a single window, or even of a particular portion of the screen 😋

@fdncred
Copy link
Collaborator

fdncred commented Jan 14, 2023

Another potential idea is to create "screenshots" without images and just create a markdown page with the appropriate colors and fake image. Or maybe an html page? Not sure exactly.

@amtoine
Copy link
Member

amtoine commented Jan 14, 2023

Another potential idea is to create "screenshots" without images and just create a markdown page with the appropriate colors and fake image. Or maybe an html page? Not sure exactly.

that could be great 😮
much lighter than raw images 👍

asciinema has the benefits or being light-weight, i.e. text-based, and nice to look at in a little video format 😌

@aidalgol
Copy link
Author

aidalgol commented Feb 4, 2023

Another potential idea is to create "screenshots" without images and just create a markdown page with the appropriate colors and fake image. Or maybe an html page? Not sure exactly.

Looks like GitHub Flavored Markdown (GFM) filters out any colour styling in raw HTML, so it seems we would have to build a website to render themes using HTML and CSS.

Since mentioning wanting to look into asciinema, I have found termshot, which looks like it does exactly what I wanted.

@aidalgol
Copy link
Author

aidalgol commented Feb 4, 2023

Blocked on homeport/termshot#102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants