Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems in auto generated custom-completion files #258

Open
tsathis opened this issue Jun 24, 2022 · 5 comments
Open

Problems in auto generated custom-completion files #258

tsathis opened this issue Jun 24, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@tsathis
Copy link

tsathis commented Jun 24, 2022

Some auto generated custom-completion files have syntax errors.
As an example the git.nu has syntax errors in following locations:

[# Display the manual of a git command

# Print out ref names
extern "git short\tHide\ prefixes full\tShow\ full\ ref\ names auto\tHide\ prefixes\ if\ printed\ to\ terminal no\tDon\\t\ display\ ref" [
...args
]

Related: #256 #257

@fdncred
Copy link
Collaborator

fdncred commented Jun 24, 2022

Agreed. It was a quick first take at auto-generating custom completions from zsh completions (I believe). Feel free to help fix these. We wanted to land these, even though they weren't perfect, in the hope that someone else would come along and help polish them off.

@fdncred fdncred added the bug Something isn't working label Jun 24, 2022
@tsathis
Copy link
Author

tsathis commented Jun 24, 2022

I'm happy to help fixing these. @fdncred Is the plan to manually correct the auto-generated scripts or only focus on correcting the generators?

@fdncred
Copy link
Collaborator

fdncred commented Jun 24, 2022

Is the plan to manually correct the...

I'd prefer that the generators be fixed myself. so, when new ones are added to other system (zsh) we can just run the generator again and get accurate custom completions. what do you think?

@tsathis
Copy link
Author

tsathis commented Jun 25, 2022

I'd prefer that the generators be fixed myself...

Yes, that would be the cleanest solution. With a good testing mechanism it will be the best option. However, in the interim allowing manual fixing of generated scripts may be good.

@fdncred
Copy link
Collaborator

fdncred commented Jun 25, 2022

ok, I'm down with whatever. there's a bunch of noop completions in here that need to be fixed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants