Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 The rendering is misaligned when the shortcode github is under the timelineItem #1404

Closed
eallion opened this issue Apr 9, 2024 · 4 comments
Labels
bug Something isn't working investigating investigating the issue

Comments

@eallion
Copy link
Contributor

eallion commented Apr 9, 2024

Describe the bug

The rendering is misaligned when the shortcode github is under the timelineItem

{{< timeline >}}

{{< timelineItem icon="hugo" header="Blowfish" badge="Apr 10, 2024" >}}
Hugo <code><a href="https://github.com/nunocoracao/blowfish" target="_blank" rel="noopener noreferrer">blowfish</a></code>
{{< github repo="nunocoracao/blowfish" >}}
{{< /timelineItem >}}

{{< /timeline >}}

To Reproduce
Steps to reproduce the behavior:

  1. Add this:
{{< timeline >}}

{{< timelineItem icon="hugo" header="Blowfish" badge="Apr 10, 2024" >}}
Hugo <code><a href="https://github.com/nunocoracao/blowfish" target="_blank" rel="noopener noreferrer">blowfish</a></code>
{{< github repo="nunocoracao/blowfish" >}}
{{< /timelineItem >}}

{{< /timeline >}}

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
Snipaste_2024-04-09_23-54-19

Desktop (please complete the following information):

  • OS: [Windows11]
  • Browser [Chrome]
  • Version [123.0.6312.106]

Hugo & Blowfish versions
All latest

Additional context

@nunocoracao
Copy link
Owner

This seems related to #864
I wonder if there is something weird happening within those divs. Need to investigate

@nunocoracao nunocoracao added bug Something isn't working investigating investigating the issue labels Apr 9, 2024
@nunocoracao nunocoracao changed the title The rendering is misaligned when the shortcode github is under the timelineItem 🐛 The rendering is misaligned when the shortcode github is under the timelineItem Apr 9, 2024
@eallion
Copy link
Contributor Author

eallion commented Apr 10, 2024

Thanks for you attention.
And markdown cannot be parsed in timelineItem.

@eallion
Copy link
Contributor Author

eallion commented May 2, 2024

nunocoracao added a commit that referenced this issue May 13, 2024
nunocoracao added a commit that referenced this issue May 13, 2024
…igned-when-the-shortcode-github-is-under-the-timelineitem

🐛 fixed #1404
@eallion
Copy link
Contributor Author

eallion commented May 14, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working investigating investigating the issue
Projects
None yet
Development

No branches or pull requests

2 participants