NUnit 4.0.0

[OsirisTerje]

See release notes
and
See migration guide

---

This discussion was created from the release NUnit 4.0.0.

[Sputnik24]

I migrated my testcase to NUnit 4.0.0 and my own console agent to NUnit 4.0.0 and NUnit.Engine 3.15.5 (was using 3.16.4 before).

Unfortunately, running the test using the local TestRunner does not work anymore.

TestEngine.WorkDirectory = Path.GetDirectoryName(testFile);
TestPackage = new TestPackage(testFile);
TestRunner = TestEngine.GetRunner(TestPackage);
TestNodes = TestRunner.Explore(TestFilter.Empty);

Gives the following:
NUnit.Engine.NUnitEngineException: An exception occurred in the driver while loading tests.
---> System.IO.FileNotFoundException: Could not load file or assembly 'TestFileAssembly, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'. Das System kann die angegebene Datei nicht finden.

Do I do something wrong?

[Sputnik24]

Hi @OsirisTerje is there an update on this topic?

[OsirisTerje]

Sorry, no progress on it. We're out of resources in the console/engine project, so it will be slow.

[stevenaw]

@Sputnik24 I noticed you mentioned you're using .NET8. I think .NET8 support was added in version 3.17 of the console runner. Have you tried to see if it works for you?

[stevenaw]

In terms of changes in 3.16 which aren't in 3.15/3.17, there were a few PRs which affected the /Drivers directory (/nunit.engine.core/Drivers) which aren't in 3.17:

• Display better message for BadImageFormatException nunit-console#1249
• Eliminate multiple loading of assembly in same AppDomain; add tests nunit-console#1250
• Better handling of dependencies when loading .NET Core assemblies nunit-console#1267

The first only looks to improve an error message but the second and third touch some of the assembly loading logic. If I'm reading it right the third may also remove a call to var assemblyPath = _resolver.ResolveAssemblyToPath(name); as part of some refactoring to the CustomAssemblyLoadContext

@Sputnik24 If 3.17 does not work for you then I would suggest to make an issue to start a discussion about porting those changes (and identifying any others), however we would want to be careful of course to not re-introduce the issues from the 3.16 branch again.

[stevenaw]

Oh. Perhaps PR https://github.com/nunit/nunit-console/pull/1376/files could help here too

[SimonCropp]

is there going to be a NUnit4TestAdapter?

[OsirisTerje]

We have an unfortunate naming issue there. We cant rename the package, so we're stuck with NUnit3Testadapter- at least until Microsoft/Nuget figures out a way to rename packages but keeping the identity. If that happens, we can rename it back to NUnitTestAdapter.
Version 4.5 of the NUnit3TestAdapter IS the de-facto version 4 of the adapter, and runs all versions of NUnit 3 and 4.

[OsirisTerje]

Also worth mentioning, moving forward we will follow Semver, so the major numbers of both will increase for breaking changes. The naming of the packages then have to remain the same. The idea of having versions in the names was very unfortunate,

[OsirisTerje]

An alternative could be to create a new package of the same with e.g. the name NUnitAdapter. But, it will be a major breaking change for very many people. So not sure if we can do this.

[seesharks]

A bit of a crossover issue, but I've upgraded to 4.0.0 (including using the analyzer to automatically port to the constraint model -- good stuff by the way -- it worked like a dream!). Now my ReSharper test runner comes up empty when scanning projects for tests. It finds none whatsoever.

The built in VS test runner with NUnit3TestAdapter installed does find and successfully run all tests. It's just ReSharper that has an issue.

Does anyone know if ReSharper is compatible with the new version?

This post seems relevant, but I am well ahead of the fix version it indicates: nunit/nunit3-vs-adapter#846

[OsirisTerje]

You're absolutely 100% correct! It doesn't work on version 2023.2, but that has just recently been fixed in 2023.3 which is in EAP now, hopefully soon released.

PS: The issue you link to is for the adapter, which Resharper is ignoring actually, but that issue was fixed. The issue now is that Rider/REsharper doesnt support NUnit 4, because they have used an outdated engine as part of their solution. Now they have fixed that too, so either try the EAP or wait for the release of 2023.3

[seesharks]

Got it, thanks for the quick response!

[PzYon]

I had the same issue. Rider 2023.3 has been released and now it works.

[hypdeb]

It's a Rider issue I guess, but still not really working for me. I usually have to invalidate caches + restart + git clean -xdf to get the tests to run correctly.